Remove partner FAQs - Part 2 #4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on this until Remove partner FAQs -- Part 1 is merged. |
jp524
force-pushed
the
4546-remove-partner-faq-part-2
branch
from
bb0e8c6 to
6a06427
Compare
|
Part 1 of this PR has been merged so I rebased my commit accordingly. This is ready to be reviewed. |
|
@dorner -- per notes above, suggest holding merging this until after part 1 is deployed. It otherwise LGTM. |
dorner
requested changes
Jan 17, 2025
db/migrate/20250104193318_remove_for_banks_and_for_partners_from_questions.rb
Outdated
Show resolved
Hide resolved
dorner
approved these changes
Jan 21, 2025
|
Thanks! |
|
@jp524: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4546
Description
Contains migration to remove columns from Question model.
According to Strong Migrations docs, this PR should be deployed only after #4912 has been deployed.
Type of change
How Has This Been Tested?
See #4912.
Screenshots
See #4912.